fix(PM-1168): QA feedbacks for assigning copilots #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -99,6 +99,7 @@ module.exports = [ | |||
| } | |||
|
|
|||
| const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id); | |||
| console.log(applicationUser, 'applicationUser'); | |||
There was a problem hiding this comment.
Remove the console.log statement used for debugging purposes. It is not recommended to leave debugging logs in production code.
| @@ -99,6 +99,7 @@ module.exports = [ | |||
| } | |||
|
|
|||
| const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id); | |||
| req.log.info(applicationUser, 'applicationUser'); | |||
There was a problem hiding this comment.
Consider removing the logging of applicationUser if it is not necessary for production. Logging sensitive information can lead to security issues.
| @@ -99,6 +99,7 @@ module.exports = [ | |||
| } | |||
|
|
|||
| const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id); | |||
| req.log.info(applicationUser, 'applicationUser asdsd', userId); | |||
There was a problem hiding this comment.
The log message seems to have a typo or unnecessary text 'asdsd'. Consider revising it to ensure clarity and relevance.
hentrymartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-1168